Messages in this thread | | | Date | Tue, 10 Mar 2020 22:31:26 -0700 | From | Nathan Chancellor <> | Subject | Re: [PATCH v4] MIPS: Replace setup_irq() by request_irq() |
| |
On Thu, Mar 05, 2020 at 05:27:53PM +0530, afzal mohammed wrote: > request_irq() is preferred over setup_irq(). Invocations of setup_irq() > occur after memory allocators are ready. > > Per tglx[1], setup_irq() existed in olden days when allocators were not > ready by the time early interrupts were initialized. > > Hence replace setup_irq() by request_irq(). > > remove_irq() has been replaced by free_irq() as well. > > There were build error's during previous version, couple of which was > reported by kbuild test robot <lkp@intel.com> of which one was reported > by Thomas Bogendoerfer <tsbogend@alpha.franken.de> as well. There were a > few more issues including build errors, those also have been fixed. > > [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos > > Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
This patch regresses booting malta_defconfig with both GCC and clang with this rootfs and QEMU 4.2.0:
https://github.com/ClangBuiltLinux/continuous-integration/blob/a85e3e44c2570847e22ad8f92f317c2b007c4517/images/mipsel/rootfs.cpio
$ timeout 2m qemu-system-mipsel -machine malta -cpu 24Kf -initrd rootfs.cpio -kernel vmlinux -m 512m -display none -serial mon:stdio
just hangs. I have not done further debugging past the initial bisect.
Cheers, Nathan
| |