Messages in this thread | | | Subject | Re: [Outreachy kernel] [PATCH] Staging: rtl8723bs: rtw_mlme: Remove unnecessary conditions | From | Lakshmi Ramasubramanian <> | Date | Wed, 11 Mar 2020 19:42:06 -0700 |
| |
On 3/11/2020 6:58 AM, Shreeya Patel wrote:
> Remove unnecessary if and else conditions since both are leading to the > initialization of "phtpriv->ampdu_enable" with the same value. > > Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
Stating this based on the patch descriptions I have seen. Others, please advise\correct me if I am wrong.
Patch description should state the problem first[1] and then describe how that is fixed in the given patch.
For example:
In the function rtw_update_ht_cap(), phtpriv->ampdu_enable is set to the same value in both if and else statements.
This patch removes this unnecessary if-else statement.
[1] Documentation\process\submitting-patches.rst 2) Describe your changes
Thanks, -lakshmi
| |