Messages in this thread | | | Subject | Re: [PATCH] checkpatch: always allow C99 SPDX License Identifer comments | From | Joe Perches <> | Date | Wed, 11 Mar 2020 19:26:12 -0700 |
| |
On Wed, 2020-03-11 at 12:11 -0700, Scott Branden wrote: > Always allow C99 comment styles if SPDK-License-Identifier is in comment > even if C99_COMMENT_TOLERANCE is specified in the --ignore options.
Why is this useful?
> Signed-off-by: Scott Branden <scott.branden@broadcom.com> > --- > scripts/checkpatch.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index a63380c6b0d2..c8b429dd6b51 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -3852,8 +3852,8 @@ sub process { > } > } > > -# no C99 // comments > - if ($line =~ m{//}) { > +# no C99 // comments except for SPDX-License-Identifier > + if ($line =~ m{//} && $rawline !~ /SPDX-License-Identifier:/) { > if (ERROR("C99_COMMENTS", > "do not use C99 // comments\n" . $herecurr) && > $fix) {
| |