lkml.org 
[lkml]   [2020]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/21] drm/tegra: remove checks for debugfs functions return value
On Wed, Mar 11, 2020 at 05:54:46PM +0300, Wambui Karuga wrote:
> Hey Thierry,
>
> On Wed, 11 Mar 2020, Thierry Reding wrote:
>
> > On Thu, Feb 27, 2020 at 03:02:21PM +0300, Wambui Karuga wrote:
> > > Since 987d65d01356 (drm: debugfs: make
> > > drm_debugfs_create_files() never fail) there is no need to check the
> > > return value of drm_debugfs_create_files(). Therefore, remove the
> > > return checks and error handling of the drm_debugfs_create_files()
> > > function from various debugfs init functions in drm/tegra and have
> > > them return 0 directly.
> > >
> > > This change also includes removing the use of drm_debugfs_create_files
> > > as a return value in tegra_debugfs_init() and have the function declared
> > > as void.
> > >
> > > Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
> > > ---
> > > drivers/gpu/drm/tegra/dc.c | 11 +----------
> > > drivers/gpu/drm/tegra/drm.c | 8 ++++----
> > > drivers/gpu/drm/tegra/dsi.c | 11 +----------
> > > drivers/gpu/drm/tegra/hdmi.c | 11 +----------
> > > drivers/gpu/drm/tegra/sor.c | 11 +----------
> > > 5 files changed, 8 insertions(+), 44 deletions(-)
> >
> > Applied, thanks.
> >
> There's a newer version[1] of this patch series as this specific patch
> depends on other work in drm.

Oh yeah, I just noticed that this patch causes a build failure, so I
backed it out again.

If there's dependencies on other work, it's probably best to take this
through drm-misc, in which case:

Acked-by: Thierry Reding <treding@nvidia.com>

Let me know if you'd prefer me to apply this to drm/tegra instead.

Thierry
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-03-12 00:25    [W:0.178 / U:0.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site