Messages in this thread | | | Date | Wed, 11 Mar 2020 22:33:09 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH v2] leds: pwm: add support for default-state device property |
| |
Hi!
> This patch adds support for "default-state" devicetree property, which > allows to defer pwm init to first use of led. > > This allows to configure the PWM early in bootloader to let the LED > blink until an application in Linux userspace set something different.
"sets".
> Signed-off-by: Denis Osterland-Heim <Denis.Osterland@diehl.com>
Looks good, I'll probably just apply it.
> index 6c6583c35f2f..d0f489680594 100644 > --- a/Documentation/devicetree/bindings/leds/leds-pwm.txt > +++ b/Documentation/devicetree/bindings/leds/leds-pwm.txt > @@ -19,6 +19,8 @@ LED sub-node properties: > see Documentation/devicetree/bindings/leds/common.txt > - linux,default-trigger : (optional) > see Documentation/devicetree/bindings/leds/common.txt > +- default-state : (optional) > + see Documentation/devicetree/bindings/leds/common.yaml >
Should other references be updated to common.yaml (as a separate patch)?
> diff --git a/include/linux/leds_pwm.h b/include/linux/leds_pwm.h > index 93d101d28943..c9ef9012913d 100644 > --- a/include/linux/leds_pwm.h > +++ b/include/linux/leds_pwm.h > @@ -10,6 +10,7 @@ struct led_pwm { > const char *default_trigger; > unsigned pwm_id __deprecated; > u8 active_low; > + u8 default_state; > unsigned max_brightness; > unsigned pwm_period_ns; > };
leds-pwm.c but leds_pwm.h. Hmm. This really should be leds-pwm.h.
Actually, leds-pwm.c is only user of leds_pwm.h, so that one should just disappear...
Best regards, Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |