Messages in this thread | | | From | rishi gupta <> | Date | Thu, 12 Mar 2020 01:16:28 +0530 | Subject | Re: [PATCH 1/1] pwm: pca9685: replace CONFIG_PM with __maybe_unused to prevent build issues |
| |
These 2 links contains more details: https://lore.kernel.org/patchwork/patch/732981 https://lkml.org/lkml/2019/1/17/437
On Wed, Mar 11, 2020 at 10:14 PM Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > > On Wed, Mar 11, 2020 at 09:13:49PM +0530, Rishi Gupta wrote: > > The __maybe_unused attribute is preferred over CONFIG_PM > > to prevent build time issues. This commit replaces CONFIG_PM > > with this attribute. > > I wasn't aware of build time issues and thought this was just about > #ifdef being ugly. > > Anyhow, the change is fine, > > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > -- > Pengutronix e.K. | Uwe Kleine-König | > Industrial Linux Solutions | https://www.pengutronix.de/ |
| |