lkml.org 
[lkml]   [2020]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [EXT] [PATCH][next] wireless: marvell: Replace zero-length array with flexible-array member
Date
Hi Gustavo,

> The current codebase makes use of the zero-length array language extension
> to the C90 standard, but the preferred mechanism to declare variable-length
> types such as these ones is a flexible array member[1][2], introduced in C99:
>
> struct foo {
> int stuff;
> struct boo array[];
> };
>
> By making use of the mechanism above, we will get a compiler warning in
> case the flexible array does not occur last in the structure, which will help us
> prevent some kind of undefined behavior bugs from being inadvertently
> introduced[3] to the codebase from now on.
>
> Also, notice that, dynamic memory allocations won't be affected by this
> change:
>
> "Flexible array members have incomplete type, and so the sizeof operator
> may not be applied. As a quirk of the original implementation of zero-length
> arrays, sizeof evaluates to zero."[1]

Thanks for this path.

Acked-by: Ganapathi Bhat <ganapathi.bhat@nxp.com>


\
 
 \ /
  Last update: 2020-03-10 05:29    [W:0.040 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site