lkml.org 
[lkml]   [2020]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.5 149/189] drm/i915/selftests: Fix return in assert_mmap_offset()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit f4aaa44e8b20f7e0d4ea68d3bca4968b6ae5aaff upstream.

    The assert_mmap_offset() returns type bool so if we return an error
    pointer that is "return true;" or success. If we have an error, then
    we should return false.

    Fixes: 3d81d589d6e3 ("drm/i915: Test exhaustion of the mmap space")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Link: https://patchwork.freedesktop.org/patch/msgid/20200228141413.qfjf4abr323drlo4@kili.mountain
    (cherry picked from commit efbf928824820f2738f41271934f6ec2c6ebd587)
    Signed-off-by: Jani Nikula <jani.nikula@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
    +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
    @@ -567,7 +567,7 @@ static bool assert_mmap_offset(struct dr

    obj = i915_gem_object_create_internal(i915, size);
    if (IS_ERR(obj))
    - return PTR_ERR(obj);
    + return false;

    err = create_mmap_offset(obj);
    i915_gem_object_put(obj);

    \
     
     \ /
      Last update: 2020-03-10 14:03    [W:3.724 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site