lkml.org 
[lkml]   [2020]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: Re: [PATCH v6 07/14] mm/damon: Implement kernel space API
Date
On Tue, 10 Mar 2020 09:01:52 +0000 Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote:

> On Mon, 24 Feb 2020 13:30:40 +0100
> SeongJae Park <sjpark@amazon.com> wrote:
>
> > From: SeongJae Park <sjpark@amazon.de>
> >
> > This commit implements the DAMON api for the kernel. Other kernel code
> > can use DAMON by calling damon_start() and damon_stop() with their own
> > 'struct damon_ctx'.
> >
> > Signed-off-by: SeongJae Park <sjpark@amazon.de>
>
> Seems like it would have been easier to create the header as you went along
> and avoid the need to have the bits here dropping static.

Yes, exporing the API from the beginning must be much simpler and easy to
review!

>
> Or the moves for that matter.
>
> Also, ideally have full kernel-doc for anything that forms part of an
> interface that is intended for use by others.

Agreed, will use the kernel-doc comments!


Thanks,
SeongJae Park

>
> Jonathan
>
> > ---
[...]

\
 
 \ /
  Last update: 2020-03-10 12:57    [W:0.061 / U:0.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site