Messages in this thread | | | From | Peng Fan <> | Subject | RE: [PATCH v2 01/14] dt-bindings: fsl: add i.MX7ULP PMC binding doc | Date | Tue, 10 Mar 2020 05:56:53 +0000 |
| |
> Subject: Re: [PATCH v2 01/14] dt-bindings: fsl: add i.MX7ULP PMC binding doc > > On Wed, Feb 19, 2020 at 03:59:44PM +0800, peng.fan@nxp.com wrote: > > From: Peng Fan <peng.fan@nxp.com> > > > > Add i.MX7ULP Power Management Controller binding doc > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > This is a new binding, and I would like get an ACK from Rob on it.
Rob,
Would you help Ack if you are fine with this patch?
> > > --- > > .../bindings/arm/freescale/imx7ulp_pmc.yaml | 32 > ++++++++++++++++++++++ > > 1 file changed, 32 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/arm/freescale/imx7ulp_pmc.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/arm/freescale/imx7ulp_pmc.yaml > > b/Documentation/devicetree/bindings/arm/freescale/imx7ulp_pmc.yaml > > new file mode 100644 > > index 000000000000..992a5ea29d39 > > --- /dev/null > > +++ > b/Documentation/devicetree/bindings/arm/freescale/imx7ulp_pmc.yaml > > @@ -0,0 +1,32 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > > +cetree.org%2Fschemas%2Fbindings%2Farm%2Ffreescale%2Fimx7ulp_pmc.y > aml% > > > +23&data=02%7C01%7Cpeng.fan%40nxp.com%7Cc1a27bc0347845099 > 80908d7c4 > > > +b6dbe3%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63719416 > 196456308 > > > +7&sdata=EJausMj4W3mpgP%2BGdKpHpyTmZY4ipbxyUAurDVTKj5A%3 > D&rese > > +rved=0 > > +$schema: > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > > +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=02%7C01%7Cpe > ng.fan% > > > +40nxp.com%7Cc1a27bc034784509980908d7c4b6dbe3%7C686ea1d3bc2b4c > 6fa92cd9 > > > +9c5c301635%7C0%7C0%7C637194161964563087&sdata=2UJYpLt69cd > NiA%2BGA > > +CI%2Bdqme0BFkqx%2FLrdt1fm3TzlM%3D&reserved=0 > > + > > +title: i.MX7ULP Power Management Controller(PMC) Device Tree Bindings > > + > > +maintainers: > > + - Peng Fan <peng.fan@nxp.com> > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - fsl,imx7ulp-pmc0 > > + - fsl,imx7ulp-pmc1 > > We usually do not encode number suffix in the compatible string. Do they > really have different programming model?
The register layout is different and some has different name/meaning. And pmc0 is used by M4, pmc1 is used by Linux.
A brief intro about pmc0/1. The PMC 0 has the following features: a high-power (HP) and a low-power (LP) Core Regulator; a high-power (HP) and a low-power (LP) Array Regulator; a high-power (HP) and a low-power (LP) 1.2V Low Voltage Detector (LVD) monitor (in regulator input); a high-power (HP) 1.8V High Voltage Detector (HVD) monitor (in regulator supply); a bandgap; a forward back bias (FBB) and a reverse back bias (RBB) regulator. a temperature sensor. The PMC 1 has the following features: a high-power (HP) and a low-power (LP) Linear LDO regulator; a set of power switches; a high-power (HP) and a low-power (LP) Low Voltage Detector (LVD) monitor; a high-power (HP) 1.2V High Voltage Detector (HVD) monitor; configurable LVD/HVD sense point between regulator supply and regulator output; a forward back bias (FBB) and a reverse back bias (RBB) regulator.
Thanks, Peng. > > Shawn > > > + > > + reg: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + > > +examples: > > + - | > > + pmc0: pmc0@410a1000 { > > + compatible = "fsl,imx7ulp-pmc0"; > > + reg = <0x410a1000 0x1000>; > > + }; > > +... > > -- > > 2.16.4 > >
| |