Messages in this thread | | | From | Nicolas Boichat <> | Date | Sun, 9 Feb 2020 20:43:35 +0800 | Subject | Re: [PATCH v4 5/7] drm/panfrost: Add support for multiple power domains |
| |
On Fri, Feb 7, 2020 at 9:52 PM Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> wrote: > > > + for (i = 0; i < ARRAY_SIZE(pfdev->pm_domain_devs); i++) { > > + if (!pfdev->pm_domain_devs[i]) > > + break;
(next time, please provide a tiny bit more context when quoting, I had to look up to see where this comes from) So this comes from panfrost_pm_domain_fini.
> I'm not totally familiar with this code, but should this be a break or > just a continue?
Check how the domains are initialized in panfrost_pm_domain_init, they are guaranteed to be "packed" at the beginning of the array, so there can't be any holes, so break is safe.
| |