Messages in this thread | | | Date | Sat, 08 Feb 2020 15:28:38 +0100 (CET) | Subject | Re: [PATCH] net: thunderx: use proper interface type for RGMII | From | David Miller <> |
| |
From: Tim Harvey <tharvey@gateworks.com> Date: Fri, 7 Feb 2020 12:40:26 -0800
> The configuration of the OCTEONTX XCV_DLL_CTL register via > xcv_init_hw() is such that the RGMII RX delay is bypassed > leaving the RGMII TX delay enabled in the MAC: > > /* Configure DLL - enable or bypass > * TX no bypass, RX bypass > */ > cfg = readq_relaxed(xcv->reg_base + XCV_DLL_CTL); > cfg &= ~0xFF03; > cfg |= CLKRX_BYP; > writeq_relaxed(cfg, xcv->reg_base + XCV_DLL_CTL); > > This would coorespond to a interface type of PHY_INTERFACE_MODE_RGMII_RXID > and not PHY_INTERFACE_MODE_RGMII. > > Fixing this allows RGMII PHY drivers to do the right thing (enable > RX delay in the PHY) instead of erroneously enabling both delays in the > PHY. > > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Applied, thanks.
| |