lkml.org 
[lkml]   [2020]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 06/28] ata: use COMMAND_LINE_SIZE for ata_force_param_buf[] size
From
Date

On 1/29/20 6:18 PM, Christoph Hellwig wrote:
> On Tue, Jan 28, 2020 at 02:33:21PM +0100, Bartlomiej Zolnierkiewicz wrote:
>> Use COMMAND_LINE_SIZE instead PAGE_SIZE for ata_force_param_buf[]
>> size as libata parameters buffer doesn't need to be bigger than
>> the command line buffer.
>>
>> For many architectures this results in decreased libata-core.o
>> size (COMMAND_LINE_SIZE varies from 256 to 4096 while the minimum
>> PAGE_SIZE is 4096).
>>
>> Code size savings on m68k arch using atari_defconfig:
>>
>> text data bss dec hex filename
>> before:
>> 41064 4413 40 45517 b1cd drivers/ata/libata-core.o
>> after:
>> 41064 573 40 41677 a2cd drivers/ata/libata-core.o
>>
>> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>
> This looks like a good start, so:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Thanks.

> But evne COMMAND_LINE_SIZE is quite a lot of overhead. Can we maybe add
> a new Kconfig option to optionally disable the libata.force= entirely?

I've added patch making "libata.force=" optional in v2
(disabling "libata.force=" saves us additional 3kB).

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

\
 
 \ /
  Last update: 2020-02-07 15:19    [W:0.085 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site