Messages in this thread | | | Subject | Re: [PATCH v2 4/9] ASoC: tegra: add Tegra210 based I2S driver | From | Sameer Pujar <> | Date | Fri, 7 Feb 2020 16:53:45 +0530 |
| |
On 2/6/2020 10:36 PM, David Laight wrote: > External email: Use caution opening links or attachments > > > From: f Dmitry Osipenko >> Sent: 06 February 2020 16:59 >> >> 30.01.2020 13:33, Sameer Pujar пишет: >> ... >>> +static const int tegra210_cif_fmt[] = { >>> + 0, >>> + TEGRA_ACIF_BITS_16, >>> + TEGRA_ACIF_BITS_32, >>> +}; >>> + >>> +static const int tegra210_i2s_bit_fmt[] = { >>> + 0, >>> + I2S_BITS_16, >>> + I2S_BITS_32, >>> +}; >>> + >>> +static const int tegra210_i2s_sample_size[] = { >>> + 0, >>> + 16, >>> + 32, >>> +}; >> static const *unsigned* int? > Or get rid of the table lookups completely. > Assuming the index is never zero then the value > can be calculated as (const_a + const_b * index).
All above tables are mapped to tegra210_i2s_format_text[]. Additions/removal of entries will require changes in equation. It is better keep the mapping as it is. > > David > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK > Registration No: 1397386 (Wales)
| |