lkml.org 
[lkml]   [2020]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 4/9] ASoC: tegra: add Tegra210 based I2S driver
From
Date


On 2/6/2020 10:36 PM, David Laight wrote:
> External email: Use caution opening links or attachments
>
>
> From: f Dmitry Osipenko
>> Sent: 06 February 2020 16:59
>>
>> 30.01.2020 13:33, Sameer Pujar пишет:
>> ...
>>> +static const int tegra210_cif_fmt[] = {
>>> + 0,
>>> + TEGRA_ACIF_BITS_16,
>>> + TEGRA_ACIF_BITS_32,
>>> +};
>>> +
>>> +static const int tegra210_i2s_bit_fmt[] = {
>>> + 0,
>>> + I2S_BITS_16,
>>> + I2S_BITS_32,
>>> +};
>>> +
>>> +static const int tegra210_i2s_sample_size[] = {
>>> + 0,
>>> + 16,
>>> + 32,
>>> +};
>> static const *unsigned* int?
> Or get rid of the table lookups completely.
> Assuming the index is never zero then the value
> can be calculated as (const_a + const_b * index).

All above tables are mapped to tegra210_i2s_format_text[].
Additions/removal of entries will require changes in equation. It is
better keep the mapping as it is.
>
> David
>
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)

\
 
 \ /
  Last update: 2020-02-07 12:25    [W:0.089 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site