Messages in this thread | | | Subject | Re: [PATCH v6 07/11] powerpc/kvm/e500: Use functions to track lockless pgtbl walks | From | Leonardo Bras <> | Date | Fri, 07 Feb 2020 00:10:02 -0300 |
| |
Hello Christophe,
On Thu, 2020-02-06 at 07:18 +0100, Christophe Leroy wrote: > > I don't really like unbalanced begin/end. > > Something like the following would be cleaner: > > > begin_lockless_pgtbl_walk() > ptep = find() > if (ptep) { > pte = READ_ONCE() > if (pte_present(pte)) > wing= > else > ret = -EINVAL; > } > end_lockless_pgtbl_walk() > > if (ret) { > pr_err_rate...() > goto out; > } > >
Sure, looks better that way. I will change that for v7.
Thanks for the feedback,
Leonardo Bras [unhandled content-type:application/pgp-signature] | |