Messages in this thread | | | From | Doug Anderson <> | Date | Thu, 6 Feb 2020 11:12:23 -0800 | Subject | Re: [PATCH v2] drm/msm: Fix a6xx GMU shutdown sequence |
| |
Hi,
On Wed, Feb 5, 2020 at 1:00 PM Rob Clark <robdclark@gmail.com> wrote: > > On Wed, Feb 5, 2020 at 12:48 PM Jordan Crouse <jcrouse@codeaurora.org> wrote: > > > > Commit e812744c5f95 ("drm: msm: a6xx: Add support for A618") missed > > updating the VBIF flush in a6xx_gmu_shutdown and instead > > inserted the new sequence into a6xx_pm_suspend along with a redundant > > GMU idle. > > > > Move a6xx_bus_clear_pending_transactions to a6xx_gmu.c and use it in > > the appropriate place in the shutdown routine and remove the redundant > > idle call. > > > > v2: Remove newly unused variable that was triggering a warning > > > > Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org> > > Reviewed-by: Rob Clark <robdclark@gmail.com>
Without this patch I'm seeing some really bad behavior where the whole system will pause for a bit, especially if it has been idle. After this patch things are much better. Thus:
Fixes: e812744c5f95 ("drm: msm: a6xx: Add support for A618") Tested-by: Douglas Anderson <dianders@chromium.org>
-Doug
| |