lkml.org 
[lkml]   [2020]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] regulator: da9063: remove redundant return statement
Done, thanks for guidance.

On Thu, Feb 6, 2020 at 5:02 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Thu, Feb 06, 2020 at 10:06:01AM +0530, Rishi Gupta wrote:
> > The devm_request_threaded_irq() already returns 0 on success
> > and negative error code on failure. So return from this itself
> > can be used while preserving error log in case of failure.
> >
> > This commit also fixes checkpatch.pl errors & warnings:
> > - WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> > - WARNING: line over 80 characters
> > - ERROR: space prohibited before that ',' (ctx:WxW)
> > - ERROR: code indent should use tabs where possible
> > - WARNING: Block comments use * on subsequent lines
>
> This should be split into separate patches, each doing one thing
> as covered in submitting-patchs.rst.

\
 
 \ /
  Last update: 2020-02-06 14:51    [W:0.031 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site