Messages in this thread | | | Subject | Re: [PATCH] x86/mce: Enable HSD131, HSM142, HSW131, BDM48, and HSM142 | From | Prarit Bhargava <> | Date | Thu, 6 Feb 2020 07:53:34 -0500 |
| |
On 2/6/20 6:10 AM, Borislav Petkov wrote: > On Wed, Feb 05, 2020 at 07:58:31AM -0500, Prarit Bhargava wrote: > >> Subject: Re: [PATCH] x86/mce: Enable HSD131, HSM142, HSW131, BDM48, and HSM142 > > That subject is unreadable for humans.
Yeah :/ I couldn't think of a better one. Maybe "Block spurious corrected errors on some Intel processors"? Any other suggestion?
> >> Intel Errata HSD131, HSM142, HSW131, and BDM48 report that >> "spurious corrected errors may be logged in the IA32_MC0_STATUS register >> with the valid field (bit 63) set, the uncorrected error field (bit 61) >> not set, a Model Specific Error Code (bits [31:16]) of 0x000F, and >> an MCA Error Code (bits [15:0]) of 0x0005." >> >> Block these spurious errors from the console and logs. > > Are they being hit in the wild or why do we need this?
Alexander, cc'd, is being hit by this in the wild.
> >> Links to Intel Specification updates: >> HSD131: https://www.intel.com/content/www/us/en/products/docs/processors/core/4th-gen-core-family-desktop-specification-update.html >> HSM142: https://www.intel.com/content/www/us/en/products/docs/processors/core/4th-gen-core-family-mobile-specification-update.html >> HSW131: https://www.intel.com/content/www/us/en/processors/xeon/xeon-e3-1200v3-spec-update.html >> BDM48: https://www.intel.com/content/www/us/en/products/docs/processors/core/5th-gen-core-family-spec-update.html > > Those links tend to get stale with time. If you really want to refer to > the PDFs, add a new bugzilla entry on https://bugzilla.kernel.org/, add > them there as an attachment and add the link to the entry to the commit > message. > >> Signed-off-by: Alexander Krupp <centos@akr.yagii.de> > > What's that Signed-off-by: tag supposed to mean? > >> Signed-off-by: Prarit Bhargava <prarit@redhat.com> >> Cc: Tony Luck <tony.luck@intel.com> >> Cc: Borislav Petkov <bp@alien8.de> >> Cc: Thomas Gleixner <tglx@linutronix.de> >> Cc: Ingo Molnar <mingo@redhat.com> >> Cc: "H. Peter Anvin" <hpa@zytor.com> >> Cc: x86@kernel.org >> Cc: linux-edac@vger.kernel.org >> --- >> arch/x86/kernel/cpu/mce/core.c | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) > > If at all, this should be done by adding an intel_filter_mce() function > and called from filter_mce() so that such errors don't get logged.
I'll take a look over there.
P.
> > Thx. >
| |