Messages in this thread | | | From | Chuanhong Guo <> | Date | Thu, 6 Feb 2020 20:33:33 +0800 | Subject | Re: [PATCH resend 1/2] spi: add driver for ar934x spi controller |
| |
On Thu, Feb 6, 2020 at 8:30 PM Chuanhong Guo <gch981213@gmail.com> wrote: > > It looks like this could just be a transfer_one() operation > > instead of transfer_one_message() (which is what this is in spite > > of the name)? There's nothing custom outside this loop that I > > can see. > > Chipselect is also handled during transfer. Controller asserts > corresponding chipselect in SHIFT_CTRL register, and if SHIFT_TERM bit > is set, controller will deassert chipselect after current transfer is > done. I need to know whether this is the last transfer and set > SHIFT_TERM accordingly.
Oh, I remembered that I saw transfer_one function name somewhere and thought maybe I could shorten the function name a bit. I'll correct this back to ar934x_spi_transfer_one_message in v2.
Regards, Chuanhong Guo
| |