Messages in this thread | | | Subject | Re: [PATCH] ata: ahci_platform: add 32-bit quirk for dwc-ahci | From | Hans de Goede <> | Date | Thu, 6 Feb 2020 12:50:06 +0100 |
| |
Hi,
On 2/6/20 12:17 PM, Roger Quadros wrote: > On TI Platforms using LPAE, SATA breaks with 64-bit DMA. > Restrict it to 32-bit. > > Cc: stable@vger.kernel.org > Signed-off-by: Roger Quadros <rogerq@ti.com> > --- > drivers/ata/ahci_platform.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c > index 3aab2e3d57f3..b925dc54cfa5 100644 > --- a/drivers/ata/ahci_platform.c > +++ b/drivers/ata/ahci_platform.c > @@ -62,6 +62,9 @@ static int ahci_probe(struct platform_device *pdev) > if (of_device_is_compatible(dev->of_node, "hisilicon,hisi-ahci")) > hpriv->flags |= AHCI_HFLAG_NO_FBS | AHCI_HFLAG_NO_NCQ; > > + if (of_device_is_compatible(dev->of_node, "snps,dwc-ahci")) > + hpriv->flags |= AHCI_HFLAG_32BIT_ONLY; > +
The "snps,dwc-ahci" is a generic (non TI specific) compatible which is e.g. also used on some exynos devices. So using that to key the setting of the 32 bit flag seems wrong to me.
IMHO it would be better to introduce a TI specific compatible and use that to match on instead (and also adjust the dts files accordingly).
Regards,
Hans
> port = acpi_device_get_match_data(dev); > if (!port) > port = &ahci_port_info; >
| |