Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Thu, 6 Feb 2020 09:06:53 +0100 | Subject | Re: [PATCH] of: clk: Make <linux/of_clk.h> self-contained |
| |
Hi Stephen,
On Wed, Feb 5, 2020 at 11:51 PM Stephen Boyd <sboyd@kernel.org> wrote: > Quoting Geert Uytterhoeven (2020-02-05 11:46:49) > > Depending on include order: > > > > include/linux/of_clk.h:11:45: warning: \u2018struct device_node\u2019 declared inside parameter list will not be visible outside of this definition or declaration > > unsigned int of_clk_get_parent_count(struct device_node *np); > > ^~~~~~~~~~~ > > include/linux/of_clk.h:12:43: warning: \u2018struct device_node\u2019 declared inside parameter list will not be visible outside of this definition or declaration > > const char *of_clk_get_parent_name(struct device_node *np, int index); > > ^~~~~~~~~~~ > > include/linux/of_clk.h:13:31: warning: \u2018struct of_device_id\u2019 declared inside parameter list will not be visible outside of this definition or declaration > > void of_clk_init(const struct of_device_id *matches); > > ^~~~~~~~~~~~ > > > > Fix this by adding forward declarations for struct device_node and > > struct of_device_id. > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- > > Noticed when cleaning up some platform code. > > I am not aware of this being triggered in upstream, but this will become a > > dependency for these cleanups. > > So apply for fixes? I'll just throw it in now.
Yep.
> Applied to clk-next.
Thanks!
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |