Messages in this thread Patch in this message | | | Date | Mon, 3 Feb 2020 09:24:27 +0100 | From | Ludovic Desroches <> | Subject | Re: [PATCH 01/10] dmaengine: at_hdmac: Substitute kzalloc with kmalloc |
| |
On Thu, Jan 23, 2020 at 02:03:02PM +0000, Tudor Ambarus - M18064 wrote: > From: Tudor Ambarus <tudor.ambarus@microchip.com> > > All members of the structure are initialized below in the function, > there is no need to use kzalloc. > > Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Hi Tudor,
It sounds good for me. Thanks for the cleanup and deadlock fixes.
For the whole set of patches: Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Ludovic
> --- > drivers/dma/at_hdmac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c > index 672c73b4a2d4..cad6dcd9cfb5 100644 > --- a/drivers/dma/at_hdmac.c > +++ b/drivers/dma/at_hdmac.c > @@ -1671,7 +1671,7 @@ static struct dma_chan *at_dma_xlate(struct of_phandle_args *dma_spec, > dma_cap_zero(mask); > dma_cap_set(DMA_SLAVE, mask); > > - atslave = kzalloc(sizeof(*atslave), GFP_KERNEL); > + atslave = kmalloc(sizeof(*atslave), GFP_KERNEL); > if (!atslave) > return NULL; > > -- > 2.23.0
| |