Messages in this thread Patch in this message | | | From | Jiri Olsa <> | Subject | [PATCH 3/5] perf expr: Increase EXPR_MAX_OTHER | Date | Fri, 28 Feb 2020 10:36:14 +0100 |
| |
We have metrics that define more than 15 variables, like Branch_Misprediction_Cost. Increasing the allowed variables count to 20.
As Andy pointed out, we can't go too high in here, because some of the code has O(n^2) complexity (already_seen) and we might want to do some other changes (like using hash tables) before increasing the maximum even more.
Signed-off-by: Jiri Olsa <jolsa@kernel.org> --- tools/perf/util/expr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/expr.h b/tools/perf/util/expr.h index 9332796e6649..df0a17df0cef 100644 --- a/tools/perf/util/expr.h +++ b/tools/perf/util/expr.h @@ -2,7 +2,7 @@ #ifndef PARSE_CTX_H #define PARSE_CTX_H 1 -#define EXPR_MAX_OTHER 15 +#define EXPR_MAX_OTHER 20 #define MAX_PARSE_ID EXPR_MAX_OTHER struct parse_id { -- 2.24.1
| |