lkml.org 
[lkml]   [2020]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 03/21] drm: convert drm_debugfs functions to return void
    Date
    Since 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never
    fail), drm_debug_create_files() never fails and should return void.
    Therefore, drop return value from various drm_debugfs functions that return
    drm_debug_create_files() and convert the functions to return void.

    Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
    ---
    drivers/gpu/drm/drm_atomic.c | 8 ++++----
    drivers/gpu/drm/drm_client.c | 8 ++++----
    drivers/gpu/drm/drm_crtc_internal.h | 2 +-
    drivers/gpu/drm/drm_framebuffer.c | 8 ++++----
    drivers/gpu/drm/drm_internal.h | 2 +-
    include/drm/drm_client.h | 2 +-
    6 files changed, 15 insertions(+), 15 deletions(-)

    diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
    index 9ccfbf213d72..965173fd0ac2 100644
    --- a/drivers/gpu/drm/drm_atomic.c
    +++ b/drivers/gpu/drm/drm_atomic.c
    @@ -1641,10 +1641,10 @@ static const struct drm_info_list drm_atomic_debugfs_list[] = {
    {"state", drm_state_info, 0},
    };

    -int drm_atomic_debugfs_init(struct drm_minor *minor)
    +void drm_atomic_debugfs_init(struct drm_minor *minor)
    {
    - return drm_debugfs_create_files(drm_atomic_debugfs_list,
    - ARRAY_SIZE(drm_atomic_debugfs_list),
    - minor->debugfs_root, minor);
    + drm_debugfs_create_files(drm_atomic_debugfs_list,
    + ARRAY_SIZE(drm_atomic_debugfs_list),
    + minor->debugfs_root, minor);
    }
    #endif
    diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c
    index b031b45aa8ef..2a147d1c3a13 100644
    --- a/drivers/gpu/drm/drm_client.c
    +++ b/drivers/gpu/drm/drm_client.c
    @@ -457,10 +457,10 @@ static const struct drm_info_list drm_client_debugfs_list[] = {
    { "internal_clients", drm_client_debugfs_internal_clients, 0 },
    };

    -int drm_client_debugfs_init(struct drm_minor *minor)
    +void drm_client_debugfs_init(struct drm_minor *minor)
    {
    - return drm_debugfs_create_files(drm_client_debugfs_list,
    - ARRAY_SIZE(drm_client_debugfs_list),
    - minor->debugfs_root, minor);
    + drm_debugfs_create_files(drm_client_debugfs_list,
    + ARRAY_SIZE(drm_client_debugfs_list),
    + minor->debugfs_root, minor);
    }
    #endif
    diff --git a/drivers/gpu/drm/drm_crtc_internal.h b/drivers/gpu/drm/drm_crtc_internal.h
    index 16f2413403aa..1b620ba9244b 100644
    --- a/drivers/gpu/drm/drm_crtc_internal.h
    +++ b/drivers/gpu/drm/drm_crtc_internal.h
    @@ -224,7 +224,7 @@ int drm_mode_dirtyfb_ioctl(struct drm_device *dev,
    /* drm_atomic.c */
    #ifdef CONFIG_DEBUG_FS
    struct drm_minor;
    -int drm_atomic_debugfs_init(struct drm_minor *minor);
    +void drm_atomic_debugfs_init(struct drm_minor *minor);
    #endif

    int __drm_atomic_helper_disable_plane(struct drm_plane *plane,
    diff --git a/drivers/gpu/drm/drm_framebuffer.c b/drivers/gpu/drm/drm_framebuffer.c
    index 57ac94ce9b9e..0375b3d7f8d0 100644
    --- a/drivers/gpu/drm/drm_framebuffer.c
    +++ b/drivers/gpu/drm/drm_framebuffer.c
    @@ -1207,10 +1207,10 @@ static const struct drm_info_list drm_framebuffer_debugfs_list[] = {
    { "framebuffer", drm_framebuffer_info, 0 },
    };

    -int drm_framebuffer_debugfs_init(struct drm_minor *minor)
    +void drm_framebuffer_debugfs_init(struct drm_minor *minor)
    {
    - return drm_debugfs_create_files(drm_framebuffer_debugfs_list,
    - ARRAY_SIZE(drm_framebuffer_debugfs_list),
    - minor->debugfs_root, minor);
    + drm_debugfs_create_files(drm_framebuffer_debugfs_list,
    + ARRAY_SIZE(drm_framebuffer_debugfs_list),
    + minor->debugfs_root, minor);
    }
    #endif
    diff --git a/drivers/gpu/drm/drm_internal.h b/drivers/gpu/drm/drm_internal.h
    index aeec2e68d772..f0c99d00b201 100644
    --- a/drivers/gpu/drm/drm_internal.h
    +++ b/drivers/gpu/drm/drm_internal.h
    @@ -235,7 +235,7 @@ int drm_syncobj_query_ioctl(struct drm_device *dev, void *data,
    /* drm_framebuffer.c */
    void drm_framebuffer_print_info(struct drm_printer *p, unsigned int indent,
    const struct drm_framebuffer *fb);
    -int drm_framebuffer_debugfs_init(struct drm_minor *minor);
    +void drm_framebuffer_debugfs_init(struct drm_minor *minor);

    /* drm_hdcp.c */
    int drm_setup_hdcp_srm(struct class *drm_class);
    diff --git a/include/drm/drm_client.h b/include/drm/drm_client.h
    index 3ed5dee899fd..7402f852d3c4 100644
    --- a/include/drm/drm_client.h
    +++ b/include/drm/drm_client.h
    @@ -188,6 +188,6 @@ int drm_client_modeset_dpms(struct drm_client_dev *client, int mode);
    drm_for_each_connector_iter(connector, iter) \
    if (connector->connector_type != DRM_MODE_CONNECTOR_WRITEBACK)

    -int drm_client_debugfs_init(struct drm_minor *minor);
    +void drm_client_debugfs_init(struct drm_minor *minor);

    #endif
    --
    2.25.0
    \
     
     \ /
      Last update: 2020-02-27 13:03    [W:3.019 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site