lkml.org 
[lkml]   [2020]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH V5 02/12] fs: Remove unneeded IS_DAX() check
    Date
    From: Ira Weiny <ira.weiny@intel.com>

    Remove the check because DAX now has it's own read/write methods and
    file systems which support DAX check IS_DAX() prior to IOCB_DIRECT on
    their own. Therefore, it does not matter if the file state is DAX when
    the iocb flags are created.

    Reviewed-by: Dave Chinner <dchinner@redhat.com>
    Reviewed-by: Jan Kara <jack@suse.cz>
    Signed-off-by: Ira Weiny <ira.weiny@intel.com>

    ---
    Changes from v3:
    Reword commit message.
    Reordered to be a 'pre-cleanup' patch
    ---
    include/linux/fs.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/include/linux/fs.h b/include/linux/fs.h
    index 3cd4fe6b845e..63d1e533a07d 100644
    --- a/include/linux/fs.h
    +++ b/include/linux/fs.h
    @@ -3388,7 +3388,7 @@ extern int file_update_time(struct file *file);

    static inline bool io_is_direct(struct file *filp)
    {
    - return (filp->f_flags & O_DIRECT) || IS_DAX(filp->f_mapping->host);
    + return (filp->f_flags & O_DIRECT);
    }

    static inline bool vma_is_dax(struct vm_area_struct *vma)
    --
    2.21.0
    \
     
     \ /
      Last update: 2020-02-27 06:34    [W:4.121 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site