Messages in this thread | | | Subject | Re: [PATCH v3 15/27] powerpc/powernv/pmem: Add support for near storage commands | From | "Alastair D'Silva" <> | Date | Fri, 28 Feb 2020 10:56:25 +1100 |
| |
On Thu, 2020-02-27 at 19:30 +1100, Andrew Donnellan wrote: > On 21/2/20 2:27 pm, Alastair D'Silva wrote:> +int > ns_response_handled(const struct ocxlpmem *ocxlpmem) > > +{ > > + return ocxl_global_mmio_set64(ocxlpmem->ocxl_afu, > > GLOBAL_MMIO_CHIC, > > + OCXL_LITTLE_ENDIAN, > > GLOBAL_MMIO_CHI_NSCRA); > > +} > > Same comment as on the last patch - I think we're meant to be > clearing > this bit, not setting it to 1, >
Same reply :) Writing to the CHIC register clears the bit in CHI.
> -- Alastair D'Silva Open Source Developer Linux Technology Centre, IBM Australia mob: 0423 762 819
| |