Messages in this thread | | | From | "Shivamurthy Shastri (sshivamurthy)" <> | Subject | RE: [EXT] Re: [PATCH v4 2/5] mtd: spinand: micron: Add new Micron SPI NAND devices | Date | Thu, 27 Feb 2020 20:16:46 +0000 |
| |
Hi Boris,
Thanks for the review.
> > On Thu, 6 Feb 2020 21:22:03 +0100 > shiva.linuxworks@gmail.com wrote: > > > From: Shivamurthy Shastri <sshivamurthy@micron.com> > > > > Add device table for M79A and M78A series Micron SPI NAND devices. > > > > Signed-off-by: Shivamurthy Shastri <sshivamurthy@micron.com> > > --- > > drivers/mtd/nand/spi/micron.c | 31 > +++++++++++++++++++++++++++++++ > > 1 file changed, 31 insertions(+) > > > > diff --git a/drivers/mtd/nand/spi/micron.c > b/drivers/mtd/nand/spi/micron.c > > index c028d0d7e236..5fd1f921ef12 100644 > > --- a/drivers/mtd/nand/spi/micron.c > > +++ b/drivers/mtd/nand/spi/micron.c > > @@ -91,6 +91,7 @@ static int micron_8_ecc_get_status(struct > spinand_device *spinand, > > } > > > > static const struct spinand_info micron_spinand_table[] = { > > + /* M79A 2Gb 3.3V */ > > Should be added in a separate patch.
Okay, I will create separate patch for each device.
> > > SPINAND_INFO("MT29F2G01ABAGD", 0x24, > > NAND_MEMORG(1, 2048, 128, 64, 2048, 40, 2, 1, 1), > > NAND_ECCREQ(8, 512), > > @@ -100,6 +101,36 @@ static const struct spinand_info > micron_spinand_table[] = { > > 0, > > SPINAND_ECCINFO(µn_8_ooblayout, > > micron_8_ecc_get_status)), > > + /* M79A 2Gb 1.8V */ > > + SPINAND_INFO("MT29F2G01ABBGD", 0x25, > > + NAND_MEMORG(1, 2048, 128, 64, 2048, 40, 2, 1, 1), > > + NAND_ECCREQ(8, 512), > > + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, > > + &write_cache_variants, > > + &update_cache_variants), > > + 0, > > + SPINAND_ECCINFO(µn_8_ooblayout, > > + micron_8_ecc_get_status)), > > + /* M78A 1Gb 3.3V */ > > + SPINAND_INFO("MT29F1G01ABAFD", 0x14, > > + NAND_MEMORG(1, 2048, 128, 64, 1024, 20, 1, 1, 1), > > + NAND_ECCREQ(8, 512), > > + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, > > + &write_cache_variants, > > + &update_cache_variants), > > + 0, > > + SPINAND_ECCINFO(µn_8_ooblayout, > > + micron_8_ecc_get_status)), > > + /* M78A 1Gb 1.8V */ > > + SPINAND_INFO("MT29F1G01ABAFD", 0x15, > > + NAND_MEMORG(1, 2048, 128, 64, 1024, 20, 1, 1, 1), > > + NAND_ECCREQ(8, 512), > > + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, > > + &write_cache_variants, > > + &update_cache_variants), > > + 0, > > + SPINAND_ECCINFO(µn_8_ooblayout, > > + micron_8_ecc_get_status)), > > }; > > > > static int micron_spinand_detect(struct spinand_device *spinand)
| |