Messages in this thread | | | Date | Thu, 27 Feb 2020 20:57:08 +0100 | From | Borislav Petkov <> | Subject | Re: [patch 2/8] x86/entry/common: Consolidate syscall entry code |
| |
On Tue, Feb 25, 2020 at 11:08:03PM +0100, Thomas Gleixner wrote: > All syscall entry points call enter_from_user_mode() and > local_irq_enable(). Move that into an inline helper so the interrupt > tracing can be moved into that helper later instead of sprinkling > it all over the place. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > --- > arch/x86/entry/common.c | 48 +++++++++++++++++++++++++++++++++--------------- > 1 file changed, 33 insertions(+), 15 deletions(-) > > --- a/arch/x86/entry/common.c > +++ b/arch/x86/entry/common.c > @@ -49,6 +49,18 @@ > static inline void enter_from_user_mode(void) {} > #endif > > +/* > + * All syscall entry variants call with interrupts disabled. > + * > + * Invoke context tracking if enabled and enable interrupts for further > + * processing. > + */ > +static __always_inline void syscall_entry_fixups(void)
Function name needs a verb. "do_syscall_entry_fixups()" seems to fit well with where it is called or "apply_..." or so.
Rest looks ok.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |