Messages in this thread | | | Subject | Re: [PATCH] sched/fair: fix runnable_avg for throttled cfs | From | Dietmar Eggemann <> | Date | Thu, 27 Feb 2020 15:17:20 +0000 |
| |
On 27.02.20 14:58, Vincent Guittot wrote: > On Thu, 27 Feb 2020 at 14:10, Vincent Guittot > <vincent.guittot@linaro.org> wrote: >> >> On Thu, 27 Feb 2020 at 12:20, Dietmar Eggemann <dietmar.eggemann@arm.com> wrote: >>> >>> On 26.02.20 21:01, Vincent Guittot wrote: >>>> On Wed, 26 Feb 2020 at 20:04, <bsegall@google.com> wrote: >>>>> >>>>> Vincent Guittot <vincent.guittot@linaro.org> writes:
[...]
>>> Shouldn't this be 'current' rather 'new' h_nr_running for >>> group_se->runnable_weight? IMHO, you want to cache the current value >>> before you add/subtract task_delta. >> >> hmm... it can't be current in both places. In my explanation, >> "current" means the current situation when we started to throttle cfs >> and "new" means the new situation after we finished to throttle the >> cfs. I should probably use old and new to prevent any >> misunderstanding. > > I'm about to send a new version to fix some minor changes: The if > statement should have some { } as there are some on the else part > > Would it be better for you if i use old and new instead of current and > new in the commit message ?
Personally yes, but now I understand the other wording as well. Thanks.
[...]
| |