lkml.org 
[lkml]   [2020]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 21/21] drm/arm: have malidp_debufs_init() return void
    On Thu, Feb 27, 2020 at 03:02:32PM +0300, Wambui Karuga wrote:
    > As there's no need for the return value in malidp_debugfs_init() after
    > the conversion of the drm_driver.debugfs_init() hook, (drm: convert the
    > .debugs_init() hook to return void), convert the malidp_debugfs_init()
    > function to return void.
    >
    > Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>

    Acked-by: Liviu Dudau <liviu.dudau@arm.com>

    Thanks!
    Liviu

    > ---
    > drivers/gpu/drm/arm/malidp_drv.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
    > index 37d92a06318e..def8c9ffafca 100644
    > --- a/drivers/gpu/drm/arm/malidp_drv.c
    > +++ b/drivers/gpu/drm/arm/malidp_drv.c
    > @@ -548,7 +548,7 @@ static const struct file_operations malidp_debugfs_fops = {
    > .release = single_release,
    > };
    >
    > -static int malidp_debugfs_init(struct drm_minor *minor)
    > +static void malidp_debugfs_init(struct drm_minor *minor)
    > {
    > struct malidp_drm *malidp = minor->dev->dev_private;
    >
    > @@ -557,7 +557,6 @@ static int malidp_debugfs_init(struct drm_minor *minor)
    > spin_lock_init(&malidp->errors_lock);
    > debugfs_create_file("debug", S_IRUGO | S_IWUSR, minor->debugfs_root,
    > minor->dev, &malidp_debugfs_fops);
    > - return 0;
    > }
    >
    > #endif //CONFIG_DEBUG_FS
    > --
    > 2.25.0
    >

    --
    ====================
    | I would like to |
    | fix the world, |
    | but they're not |
    | giving me the |
    \ source code! /
    ---------------
    ¯\_(ツ)_/¯

    \
     
     \ /
      Last update: 2020-02-27 15:54    [W:4.453 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site