Messages in this thread | | | From | Masahiro Yamada <> | Date | Thu, 27 Feb 2020 02:47:16 +0900 | Subject | Re: [PATCH 1/5] kbuild: fix DT binding schema rule to detect command line changes |
| |
On Tue, Feb 25, 2020 at 1:32 PM Masahiro Yamada <masahiroy@kernel.org> wrote: > > Hi Rob, > > On Tue, Feb 25, 2020 at 7:52 AM Rob Herring <robh@kernel.org> wrote: > > > > On Sun, Feb 23, 2020 at 04:04:31AM +0900, Masahiro Yamada wrote: > > > This if_change_rule is not working; it cannot detect any command line > > > changes. > > > > > > The reason is because cmd-check in scripts/Kbuild.include compares > > > $(cmd_$@) and $(cmd_$1), but cmd_dtc_dt_yaml does not exist here. > > > > > > For if_change_rule to work properly, the stem part of cmd_* and rule_* > > > must match. Because this cmd_and_fixdep invokes cmd_dtc, this rule must > > > be named rule_dtc. > > > > > > Fixes: 4f0e3a57d6eb ("kbuild: Add support for DT binding schema checks") > > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > > > --- > > > > > > scripts/Makefile.lib | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > For the series, > > > > Acked-by: Rob Herring <robh@kernel.org> > > > > I'm assuming you will take these? If not, I can in the DT tree. > > Yes, I will queue these to kbuild tree. > >
Applied with Rob's Ack.
-- Best Regards Masahiro Yamada
| |