Messages in this thread | | | From | John Ogness <> | Subject | Re: [PATCH 0/2] printk: replace ringbuffer | Date | Tue, 25 Feb 2020 20:27:40 +0100 |
| |
On 2020-02-17, Petr Mladek <pmladek@suse.com> wrote: > Alternative solution would be to get rid of record_print_text() > and use record_print_text_inline() everywhere. It will have some > advantages: > > + _inline() variant will get real testing > + no code duplication > + saving the extra buffer also in console, sysfs, and devkmsg > interface.
In preparation for my v2, I implemented this alternate approach. Rather than introducing record_print_text_inline(), I changed record_print_text() to work inline and also it will no longer handle the counting case. The callers of record_print_text() for counting will now call the new counting functions. IMHO it is a nice cleanup and also removes the static printk_record structs for console and syslog.
Thanks.
John Ogness
| |