Messages in this thread | | | Date | Tue, 25 Feb 2020 21:22:37 +1100 | From | Herbert Xu <> | Subject | Re: [PATCH -next] crypto: hisilicon - qm depends on UACCE |
| |
On Tue, Feb 25, 2020 at 04:44:57PM +0800, Zhou Wang wrote: > > > diff --git a/drivers/crypto/hisilicon/Kconfig b/drivers/crypto/hisilicon/Kconfig > > index 8851161f722f..b35c2ec15bc2 100644 > > --- a/drivers/crypto/hisilicon/Kconfig > > +++ b/drivers/crypto/hisilicon/Kconfig > > @@ -40,6 +40,7 @@ config CRYPTO_DEV_HISI_QM > > tristate > > depends on ARM64 || COMPILE_TEST > > depends on PCI && PCI_MSI > > + depends on UACCE > > help > > HiSilicon accelerator engines use a common queue management > > interface. Specific engine driver may use this module. > > > > Indeed, this driver does not depend on uacce fully, as if there is no uacce, it still can > register to kernel crypto. > > Seems that changing uacce config to bool can avoid this problem.
You shouldn't make it a bool. The standard way to solve this is to add this:
depends on UACCE || UACCE=n
Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |