lkml.org 
[lkml]   [2020]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: LKFT: arm x15: mmc1: cache flush error -110
    Date

    On 24/02/2020 11:16, Ulf Hansson wrote:
    > + Adrian
    >
    > On Fri, 21 Feb 2020 at 20:44, Bitan Biswas <bbiswas@nvidia.com> wrote:
    >>
    >> On 2/21/20 1:48 AM, Ulf Hansson wrote:
    >>> External email: Use caution opening links or attachments
    >>>
    >>>
    >>> On Thu, 20 Feb 2020 at 18:54, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
    >>>>
    >>>> On Wed, 19 Feb 2020 at 21:54, Ulf Hansson <ulf.hansson@linaro.org> wrote:
    >>>>>
    >>>>> On Thu, 13 Feb 2020 at 16:43, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
    >>>>>>
    >>>>>
    >>>>> Try to restore the value for the cache flush timeout, by updating the
    >>>>> define MMC_CACHE_FLUSH_TIMEOUT_MS to 10 * 60 * 1000".
    >>>>
    >>>> I have increased the timeout to 10 minutes but it did not help.
    >>>> Same error found.
    >>>> [ 608.679353] mmc1: Card stuck being busy! mmc_poll_for_busy
    >>>> [ 608.684964] mmc1: cache flush error -110
    >>>> [ 608.689005] blk_update_request: I/O error, dev mmcblk1, sector
    >>>> 4302400 op 0x1:(WRITE) flags 0x20800 phys_seg 1 prio class 0
    >>>>
    >>>> OTOH, What best i could do for my own experiment to revert all three patches and
    >>>> now the reported error gone and device mount successfully [1].
    >>>>
    >>>> List of patches reverted,
    >>>> mmc: core: Specify timeouts for BKOPS and CACHE_FLUSH for eMMC
    >>>> mmc: block: Use generic_cmd6_time when modifying
    >>>> INAND_CMD38_ARG_EXT_CSD
    >>>> mmc: core: Default to generic_cmd6_time as timeout in __mmc_switch()


    Reverting all the above also fixes the problem for me.

    >> I find that from the commit the changes in mmc_flush_cache below is
    >> the cause.
    >>
    >> ##
    >> @@ -961,7 +963,8 @@ int mmc_flush_cache(struct mmc_card *card)
    >> (card->ext_csd.cache_size > 0) &&
    >> (card->ext_csd.cache_ctrl & 1)) {
    >> err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
    >> - EXT_CSD_FLUSH_CACHE, 1, 0);
    >> + EXT_CSD_FLUSH_CACHE, 1,
    >> + MMC_CACHE_FLUSH_TIMEOUT_MS);


    I no longer see the issue on reverting the above hunk as Bitan suggested
    but now I see the following (which is expected) ...

    WARNING KERN mmc1: unspecified timeout for CMD6 - use generic

    > Just as a quick sanity test, please try the below patch, which
    > restores the old cache flush timeout to 10min.
    >
    > However, as I indicated above, this seems to be a problem that needs
    > to be fixed at in the host driver side. For the sdhci driver, there is
    > a bit of a tricky logic around how to deal with timeouts in
    > sdhci_send_command(). My best guess is that's where we should look
    > more closely (and I am doing that).
    >
    > From: Ulf Hansson <ulf.hansson@linaro.org>
    > Date: Mon, 24 Feb 2020 11:43:33 +0100
    > Subject: [PATCH] mmc: core: Restore busy timeout for eMMC cache flushing
    >
    > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    > ---
    > drivers/mmc/core/mmc_ops.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c
    > index da425ee2d9bf..713e7dd6d028 100644
    > --- a/drivers/mmc/core/mmc_ops.c
    > +++ b/drivers/mmc/core/mmc_ops.c
    > @@ -21,7 +21,7 @@
    >
    > #define MMC_OPS_TIMEOUT_MS (10 * 60 * 1000) /* 10min*/
    > #define MMC_BKOPS_TIMEOUT_MS (120 * 1000) /* 120s */
    > -#define MMC_CACHE_FLUSH_TIMEOUT_MS (30 * 1000) /* 30s */
    > +#define MMC_CACHE_FLUSH_TIMEOUT_MS (10 * 60 * 1000) /* 10min */

    This does not fix the problem for me.

    Jon

    --
    nvpublic

    \
     
     \ /
      Last update: 2020-02-25 11:05    [W:4.663 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site