lkml.org 
[lkml]   [2020]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: net: UDP tunnel encapsulation module for tunnelling different
Date
HI Colin

David had fixed this issue in the below commit.

c102b6f bareudp: Fix uninitialized variable warnings.

Regards,
Martin

-----Original Message-----
From: Colin Ian King <colin.king@canonical.com>
Sent: Wednesday, February 26, 2020 4:35 AM
To: Varghese, Martin (Nokia - IN/Bangalore) <martin.varghese@nokia.com>; David S. Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>; Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>; netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: re: net: UDP tunnel encapsulation module for tunnelling different

Hi,

Static analysis with Coverity detected an issue in function bareudp_xmit_skb with the return of an uninitialized value in variable err in the following commit:

commit 571912c69f0ed731bd1e071ade9dc7ca4aa52065
Author: Martin Varghese <martin.varghese@nokia.com>
Date: Mon Feb 24 10:57:50 2020 +0530

net: UDP tunnel encapsulation module for tunnelling different protocols like MPLS, IP, NSH etc.

The analysis is as follows:

var_decl: Declaring variable err without initializer.

301 int err;
302

...

344 free_dst:
345 dst_release(&rt->dst);

Uninitialized scalar variable (UNINIT)
uninit_use: Using uninitialized value err.

346 return err;
347 }

and also in function bareudp6_xmit_skb:

var_decl: Declaring variable err without initializer.

364 int err;
365

...

404
405 free_dst:
406 dst_release(dst);

Uninitialized scalar variable (UNINIT)
uninit_use: Using uninitialized value err.

407 return err;
408 }

Colin
\
 
 \ /
  Last update: 2020-02-26 05:11    [W:0.042 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site