Messages in this thread | | | Subject | Re: [PATCH 3/3] hwmon: (ina2xx) Add support for ina260 | From | Guenter Roeck <> | Date | Tue, 25 Feb 2020 18:16:19 -0800 |
| |
On 2/24/20 3:26 PM, Franz Forstmayr wrote: > Add initial support for INA260 power monitor with integrated shunt. > Registers are different from other INA2xx devices, that's why a small > translation table is used. > > Signed-off-by: Franz Forstmayr <forstmayr.franz@gmail.com>
I think the chip is sufficiently different to other chips that a separate driver would make much more sense than adding support to the existing driver. There is no calibration, registers are different, the retry logic is not needed. A new driver could use the with_info API and would be much simpler while at the same time not messing up the existing driver.
Guenter
| |