lkml.org 
[lkml]   [2020]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] arch: arm64: xilinx: Make zynqmp_firmware driver optional
From
Date
Hi Michal,

> ------Original Message------
> From: Michal Simek <michal.simek@xilinx.com>
> Sent: Monday, February 24, 2020 2:43AM
> To: Jolly Shah <jolly.shah@xilinx.com>, Ard.biesheuvel@linaro.org
<ard.biesheuvel@linaro.org>, Mingo@kernel.org <mingo@kernel.org>, 'Greg
Kh' <gregkh@linuxfoundation.org>, Matt@codeblueprint.co.uk
<matt@codeblueprint.co.uk>, Sudeep.holla@arm.com <sudeep.holla@arm.com>,
Hkallweit1@gmail.com <hkallweit1@gmail.com>, Keescook@chromium.org
<keescook@chromium.org>, Dmitry.torokhov@gmail.com
<dmitry.torokhov@gmail.com>, Michal Simek <michal.simek@xilinx.com>
> Cc: Rajan Vaja <rajanv@xilinx.com>,
Linux-arm-kernel@lists.infradead.org
<linux-arm-kernel@lists.infradead.org>, Linux-kernel@vger.kernel.org
<linux-kernel@vger.kernel.org>, Tejas Patel <tejas.patel@xilinx.com>
> Subject: Re: [PATCH 2/2] arch: arm64: xilinx: Make zynqmp_firmware
driver optional
>
> On 09. 01. 20 20:06, Jolly Shah wrote:
>> From: Tejas Patel <tejas.patel@xilinx.com>
>>
>> Zynqmp firmware driver requires firmware to be present in system.
>> Zynqmp firmware driver will crash if firmware is not present in system.
>> For example single arch QEMU, may not have firmware, with such setup
>> Linux booting fails.
>
>
> I think that moving it to firmware Kconfig is good solution. What it is
> wrong is that description above where I agree with Sudeep.
> It means.
> 1. User should have option to disable zynqmp firmware driver which is
> what this patch allows. It means if someone decides to use different
> firmware mechanism it can do it directly by simply y/n option.
>
> 2. Autodetection of PMUFW presence is another feature which could be
> implemented to have this driver enabled but different mechanism can be
> used.
>
> 3. Doing this because of missing feature in QEMU is IMHO wrong. QEMU
> should be fixed and then you don't have any issue if this should be used
> or not.
>
> Just a summary. Remove that QEMU example from commit message and talk to
> Edgar to fix single QEMU solution to have that regs mapped all the time.

Pushed another patch as suggested. Will sync up with Edgar.

Thanks,
Jolly Shah

>
> Thanks,
> Michal
>

\
 
 \ /
  Last update: 2020-02-26 01:13    [W:0.111 / U:0.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site