lkml.org 
[lkml]   [2020]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 16/24] x86/entry: Convert Invalid TSS exception to IDTENTRY
    Convert #TS to IDTENTRY_ERRORCODE:
    - Implement the C entry point with DEFINE_IDTENTRY
    - Emit the ASM stub with DECLARE_IDTENTRY
    - Remove the ASM idtentry in 64bit
    - Remove the open coded ASM entry code in 32bit
    - Fixup the XEN/PV code
    - Remove the old prototyoes

    No functional change.

    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    ---
    arch/x86/entry/entry_32.S | 6 ------
    arch/x86/entry/entry_64.S | 1 -
    arch/x86/include/asm/idtentry.h | 3 +++
    arch/x86/include/asm/traps.h | 3 ---
    arch/x86/kernel/idt.c | 2 +-
    arch/x86/kernel/traps.c | 7 ++++++-
    arch/x86/xen/enlighten_pv.c | 2 +-
    arch/x86/xen/xen-asm_64.S | 2 +-
    8 files changed, 12 insertions(+), 14 deletions(-)

    --- a/arch/x86/entry/entry_32.S
    +++ b/arch/x86/entry/entry_32.S
    @@ -1327,12 +1327,6 @@ SYM_CODE_START(native_iret)
    SYM_CODE_END(native_iret)
    #endif

    -SYM_CODE_START(invalid_TSS)
    - ASM_CLAC
    - pushl $do_invalid_TSS
    - jmp common_exception
    -SYM_CODE_END(invalid_TSS)
    -
    SYM_CODE_START(segment_not_present)
    ASM_CLAC
    pushl $do_segment_not_present
    --- a/arch/x86/entry/entry_64.S
    +++ b/arch/x86/entry/entry_64.S
    @@ -1061,7 +1061,6 @@ apicinterrupt IRQ_WORK_VECTOR irq_work
    * Exception entry points.
    */

    -idtentry X86_TRAP_TS invalid_TSS do_invalid_TSS has_error_code=1
    idtentry X86_TRAP_NP segment_not_present do_segment_not_present has_error_code=1
    idtentry X86_TRAP_SS stack_segment do_stack_segment has_error_code=1
    idtentry X86_TRAP_GP general_protection do_general_protection has_error_code=1
    --- a/arch/x86/include/asm/idtentry.h
    +++ b/arch/x86/include/asm/idtentry.h
    @@ -128,4 +128,7 @@ DECLARE_IDTENTRY(X86_TRAP_UD, exc_inval
    DECLARE_IDTENTRY(X86_TRAP_NM, exc_device_not_available);
    DECLARE_IDTENTRY(X86_TRAP_OLD_MF, exc_coproc_segment_overrun);

    +/* Simple exception entries with error code pushed by hardware */
    +DECLARE_IDTENTRY_ERRORCODE(X86_TRAP_TS, exc_invalid_tss);
    +
    #endif
    --- a/arch/x86/include/asm/traps.h
    +++ b/arch/x86/include/asm/traps.h
    @@ -16,7 +16,6 @@ asmlinkage void nmi(void);
    #ifdef CONFIG_X86_64
    asmlinkage void double_fault(void);
    #endif
    -asmlinkage void invalid_TSS(void);
    asmlinkage void segment_not_present(void);
    asmlinkage void stack_segment(void);
    asmlinkage void general_protection(void);
    @@ -34,7 +33,6 @@ asmlinkage void simd_coprocessor_error(v
    asmlinkage void xen_xennmi(void);
    asmlinkage void xen_xendebug(void);
    asmlinkage void xen_double_fault(void);
    -asmlinkage void xen_invalid_TSS(void);
    asmlinkage void xen_segment_not_present(void);
    asmlinkage void xen_stack_segment(void);
    asmlinkage void xen_general_protection(void);
    @@ -53,7 +51,6 @@ dotraplinkage void do_nmi(struct pt_regs
    #if defined(CONFIG_X86_64) || defined(CONFIG_DOUBLEFAULT)
    dotraplinkage void do_double_fault(struct pt_regs *regs, long error_code, unsigned long cr2);
    #endif
    -dotraplinkage void do_invalid_TSS(struct pt_regs *regs, long error_code);
    dotraplinkage void do_segment_not_present(struct pt_regs *regs, long error_code);
    dotraplinkage void do_stack_segment(struct pt_regs *regs, long error_code);
    dotraplinkage void do_general_protection(struct pt_regs *regs, long error_code);
    --- a/arch/x86/kernel/idt.c
    +++ b/arch/x86/kernel/idt.c
    @@ -76,7 +76,7 @@ static const __initconst struct idt_data
    INTG(X86_TRAP_UD, asm_exc_invalid_op),
    INTG(X86_TRAP_NM, asm_exc_device_not_available),
    INTG(X86_TRAP_OLD_MF, asm_exc_coproc_segment_overrun),
    - INTG(X86_TRAP_TS, invalid_TSS),
    + INTG(X86_TRAP_TS, asm_exc_invalid_tss),
    INTG(X86_TRAP_NP, segment_not_present),
    INTG(X86_TRAP_SS, stack_segment),
    INTG(X86_TRAP_GP, general_protection),
    --- a/arch/x86/kernel/traps.c
    +++ b/arch/x86/kernel/traps.c
    @@ -302,6 +302,12 @@ DEFINE_IDTENTRY(exc_coproc_segment_overr
    X86_TRAP_OLD_MF, SIGFPE, 0, NULL);
    }

    +DEFINE_IDTENTRY_ERRORCODE(exc_invalid_tss)
    +{
    + do_error_trap(regs, error_code, "invalid TSS", X86_TRAP_TS, SIGSEGV,
    + 0, NULL);
    +}
    +
    #define IP ((void __user *)uprobe_get_trap_addr(regs))
    #define DO_ERROR(trapnr, signr, sicode, addr, str, name) \
    dotraplinkage void do_##name(struct pt_regs *regs, long error_code) \
    @@ -309,7 +315,6 @@ dotraplinkage void do_##name(struct pt_r
    do_error_trap(regs, error_code, str, trapnr, signr, sicode, addr); \
    }

    -DO_ERROR(X86_TRAP_TS, SIGSEGV, 0, NULL, "invalid TSS", invalid_TSS)
    DO_ERROR(X86_TRAP_NP, SIGBUS, 0, NULL, "segment not present", segment_not_present)
    DO_ERROR(X86_TRAP_SS, SIGBUS, 0, NULL, "stack segment", stack_segment)
    DO_ERROR(X86_TRAP_AC, SIGBUS, BUS_ADRALN, NULL, "alignment check", alignment_check)
    --- a/arch/x86/xen/enlighten_pv.c
    +++ b/arch/x86/xen/enlighten_pv.c
    @@ -625,7 +625,7 @@ static struct trap_array_entry trap_arra
    TRAP_ENTRY(exc_invalid_op, false ),
    TRAP_ENTRY(exc_device_not_available, false ),
    TRAP_ENTRY(exc_coproc_segment_overrun, false ),
    - { invalid_TSS, xen_invalid_TSS, false },
    + TRAP_ENTRY(exc_invalid_tss, false ),
    { segment_not_present, xen_segment_not_present, false },
    { stack_segment, xen_stack_segment, false },
    { general_protection, xen_general_protection, false },
    --- a/arch/x86/xen/xen-asm_64.S
    +++ b/arch/x86/xen/xen-asm_64.S
    @@ -39,7 +39,7 @@ xen_pv_trap asm_exc_invalid_op
    xen_pv_trap asm_exc_device_not_available
    xen_pv_trap double_fault
    xen_pv_trap asm_exc_coproc_segment_overrun
    -xen_pv_trap invalid_TSS
    +xen_pv_trap asm_exc_invalid_tss
    xen_pv_trap segment_not_present
    xen_pv_trap stack_segment
    xen_pv_trap general_protection
    \
     
     \ /
      Last update: 2020-02-26 00:26    [W:4.190 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site