lkml.org 
[lkml]   [2020]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] null_blk: remove unused 'll_list' in 'nullb_cmd'
From
Date
nullb_cmd->list is no longer used as well. I would send v2.

Dongli Zhang

On 2/24/20 9:24 AM, Dongli Zhang wrote:
> The 'll_list' is no longer used since commit 3c395a969acc ("null_blk: set a
> separate timer for each command").
>
> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
> ---
> drivers/block/null_blk.h | 1 -
> drivers/block/null_blk_main.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/block/null_blk.h b/drivers/block/null_blk.h
> index bc837862b767..34fec8814bf1 100644
> --- a/drivers/block/null_blk.h
> +++ b/drivers/block/null_blk.h
> @@ -15,7 +15,6 @@
>
> struct nullb_cmd {
> struct list_head list;
> - struct llist_node ll_list;
> struct __call_single_data csd;
> struct request *rq;
> struct bio *bio;
> diff --git a/drivers/block/null_blk_main.c b/drivers/block/null_blk_main.c
> index 16510795e377..07301c72b102 100644
> --- a/drivers/block/null_blk_main.c
> +++ b/drivers/block/null_blk_main.c
> @@ -1519,7 +1519,6 @@ static int setup_commands(struct nullb_queue *nq)
> for (i = 0; i < nq->queue_depth; i++) {
> cmd = &nq->cmds[i];
> INIT_LIST_HEAD(&cmd->list);
> - cmd->ll_list.next = NULL;
> cmd->tag = -1U;
> }
>
>

\
 
 \ /
  Last update: 2020-02-24 18:46    [W:0.029 / U:1.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site