Messages in this thread | | | Subject | Re: [PATCH] net: bcmgenet: Clear ID_MODE_DIS in EXT_RGMII_OOB_CTRL when not needed | From | Florian Fainelli <> | Date | Mon, 24 Feb 2020 09:23:32 -0800 |
| |
On 2/24/20 8:30 AM, Nicolas Saenz Julienne wrote: > On Mon, 2020-02-24 at 18:28 +0200, Leon Romanovsky wrote: >> On Mon, Feb 24, 2020 at 04:36:09PM +0100, Nicolas Saenz Julienne wrote: >>> Outdated Raspberry Pi 4 firmware might configure the external PHY as >>> rgmii although the kernel currently sets it as rgmii-rxid. This makes >>> connections unreliable as ID_MODE_DIS is left enabled. To avoid this, >>> explicitly clear that bit whenever we don't need it. >>> >>> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> >>> Fixes: da38802211cc ("net: bcmgenet: Add RGMII_RXID support") >> >> The expectation is that Fixes line comes before SOB line. > > Ouch, sorry for that. > > I'll edit that on v2.
And you will want to indicate which tree you are targeting:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.rst#n78 -- Florian
| |