Messages in this thread | | | From | Rob Herring <> | Date | Mon, 24 Feb 2020 09:15:05 -0600 | Subject | Re: [PATCH RFC] Bindings: nvmem: add bindings for JZ4780 efuse |
| |
On Mon, Feb 24, 2020 at 12:48 AM Andreas Kemnade <andreas@kemnade.info> wrote: > > On Thu, 20 Feb 2020 13:53:55 -0600 > Rob Herring <robh@kernel.org> wrote: > > [...] > > > + > > > +required: > > > + - compatible > > > + - reg > > > + - clock > > > > 'make dt_binding_check' would have pointed the error here for you: > > > I did run make dt_binding_check... > It stopped because the jz4780-cgu.h included was missing. Then I have added > that line and have started dt_binding_check again. > At least here it is doing a full rerun in the second part. > After some time I scrolled back and noticed DTC passed > and missed that > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.example.dt.yaml: > > efuse@134100d0: 'clock' is a required property > > > in the CHECKS line. Well, dt_binding_check is a bit noisy. I guess I should > have redirected all output to a text file, before and after my changes. and > diffed the results. > Is there any script ready for that?
grep 'ingenic,jz4780-efuse' <build log> ?
Noisy? There's 8 warnings on Linus' master currently[1]. I try to keep that at 0, but I wouldn't call 8 noisy.
Rob
[1] https://gitlab.com/robherring/linux-dt-bindings/-/jobs/447630363
| |