lkml.org 
[lkml]   [2020]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [linux-sunxi] Re: [PATCH 0/4] Add support for charger LED for AXP813 and TBS A711 Tablet
From
Date

On 2/23/20 3:35 PM, Ondřej Jirman wrote:
> On Sun, Feb 23, 2020 at 02:27:30PM +0100, megous hlavni wrote:
>> On Sun, Feb 23, 2020 at 02:14:31PM +0100, megous hlavni wrote:
>>> The tablet has a charger LED exposed on the top. This LED is controlled
>>> by AXP813 PMIC. Add support for enabling the LED and using it either
>>> for charging indication (handled by PMIC automatically) or for other uses
>>> via user control.
>> Dang, I just noticed someone sent a similar driver recently, although I had this
>> one prepared for quite some time (since 2017) in my tree. I guess I should have
>> sent it earlier.
>>
>> Please ignore.
> Though the meaning of "recently" is a bit relative. The other work was sent in
> a year ago. Here's a reference:
>
> https://lore.kernel.org/patchwork/cover/1042764/

Hi,

I'm the author of the 'other' work. I don't know the full story here,
but I don't
mind someone else submitting this patch as his.

When I submitted the last patch, there was the proposal to use the
ledtrig-pattern instead
of sysfs entries. Also AXP209 has inverted CTRL bit.

Please read the the 'other' discussion.

Best regards,
Stefan Mavrodiev

>
>> regards,
>> o.
>>
>>
>>> Please take a look.
>>>
>>> thank you and regards,
>>> Ondrej Jirman
>>>
>>> Ondrej Jirman (4):
>>> dt-bindings: leds: Add a binding for AXP813 charger led
>>> leds: axp20x: Support charger LED on AXP20x like PMICs
>>> ARM: dts: axp813: Add charger LED
>>> ARM: dts: sun8i-a83t-tbs-a711: Enable charging LED
>>>
>>> .../devicetree/bindings/leds/leds-axp20x.yaml | 24 ++
>>> arch/arm/boot/dts/axp81x.dtsi | 5 +
>>> arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 4 +
>>> drivers/leds/Kconfig | 7 +
>>> drivers/leds/Makefile | 1 +
>>> drivers/leds/leds-axp20x.c | 240 ++++++++++++++++++
>>> drivers/mfd/axp20x.c | 3 +
>>> 7 files changed, 284 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/leds/leds-axp20x.yaml
>>> create mode 100644 drivers/leds/leds-axp20x.c
>>>
>>> --
>>> 2.25.1
>>>

\
 
 \ /
  Last update: 2020-02-24 07:32    [W:0.070 / U:1.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site