Messages in this thread | | | Subject | Re: [PATCH v2] irqchip/bcm2835: Quiesce IRQs left enabled by bootloader | From | Stefan Wahren <> | Date | Mon, 24 Feb 2020 10:21:39 +0100 |
| |
Hi Lukas,
On 23.02.20 19:24, Lukas Wunner wrote: > On Sun, Feb 23, 2020 at 06:59:56PM +0100, Stefan Wahren wrote: >> thanks for all the investigation. Unfortunately the patch below doesn't >> compile, since it lacks the definiton of REG_FIQ_ENABLE. > Ugh, I recall fixing that when compile-testing. I must have forgotten > to invoke "git commit --amend" before "git format-patch". > >> Btw the name is a little bit unlucky because it defines a single flag >> within REG_FIQ_CONTROL instead of a separate register. > The Foundation's repo uses that name so I stuck by it to reduce the > number of merge conflicts Phil will have to resolve. Happy to change > though, suggestions welcome.
readability has a higher prio. How about:
#define FIQ_CONTROL_ENABLE BIT(7)
Regards Stefan
| |