lkml.org 
[lkml]   [2020]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] pwm: omap-dmtimer: Drop unused header file
Hello,

On Mon, Feb 24, 2020 at 10:51:32AM +0530, Lokesh Vutla wrote:
> @@ -190,9 +190,8 @@ static int pwm_omap_dmtimer_config(struct pwm_chip *chip,
> load_value, load_value, match_value, match_value);
>
> omap->pdata->set_pwm(omap->dm_timer,
> - pwm_get_polarity(pwm) == PWM_POLARITY_INVERSED,
> - true,
> - PWM_OMAP_DMTIMER_TRIGGER_OVERFLOW_AND_COMPARE);
> + pwm_get_polarity(pwm) == PWM_POLARITY_INVERSED,
> + true, OMAP_TIMER_TRIGGER_OVERFLOW_AND_COMPARE);

This is unrelated.

>
> /* If config was called while timer was running it must be reenabled. */
> if (timer_active)
> @@ -220,9 +219,8 @@ static int pwm_omap_dmtimer_set_polarity(struct pwm_chip *chip,
> */
> mutex_lock(&omap->mutex);
> omap->pdata->set_pwm(omap->dm_timer,
> - polarity == PWM_POLARITY_INVERSED,
> - true,
> - PWM_OMAP_DMTIMER_TRIGGER_OVERFLOW_AND_COMPARE);
> + polarity == PWM_POLARITY_INVERSED,
> + true, OMAP_TIMER_TRIGGER_OVERFLOW_AND_COMPARE);

ditto

> mutex_unlock(&omap->mutex);
>
> return 0;
> @@ -244,7 +242,7 @@ static int pwm_omap_dmtimer_probe(struct platform_device *pdev)
> struct pwm_omap_dmtimer_chip *omap;
> struct dmtimer_platform_data *timer_pdata;
> const struct omap_dm_timer_ops *pdata;
> - pwm_omap_dmtimer *dm_timer;
> + struct omap_dm_timer *dm_timer;
> u32 v;
> int ret = 0;
>

Other than that looks fine.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

\
 
 \ /
  Last update: 2020-02-24 08:53    [W:0.071 / U:1.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site