Messages in this thread | | | Date | Mon, 24 Feb 2020 13:57:43 -0800 | From | Christoph Hellwig <> | Subject | Re: [PATCH v7 14/24] btrfs: Convert from readpages to readahead |
| |
On Mon, Feb 24, 2020 at 01:54:14PM -0800, Matthew Wilcox wrote: > > First I think the implicit ARRAY_SIZE in readahead_page_batch is highly > > dangerous, as it will do the wrong thing when passing a pointer or > > function argument. > > somebody already thought of that ;-) > > #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
Ok. Still find it pretty weird to design a primary interface that just works with an array type.
| |