lkml.org 
[lkml]   [2020]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH v2 09/18] parisc: Replace setup_irq() by request_irq()
    request_irq() is preferred over setup_irq(). The early boot setup_irq()
    invocations happen either via 'init_IRQ()' or 'time_init()', while
    memory allocators are ready by 'mm_init()'.

    Per tglx[1], setup_irq() existed in olden days when allocators were not
    ready by the time early interrupts were initialized.

    Hence replace setup_irq() by request_irq().

    Seldom remove_irq() usage has been observed coupled with setup_irq(),
    wherever that has been found, it too has been replaced by free_irq().

    [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos

    Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
    ---

    v2:
    * Replace pr_err("request_irq() on %s failed" by
    pr_err("%s: request_irq() failed"
    * Commit message massage

    arch/parisc/kernel/irq.c | 21 +++++----------------
    drivers/parisc/eisa.c | 8 ++------
    2 files changed, 7 insertions(+), 22 deletions(-)

    diff --git a/arch/parisc/kernel/irq.c b/arch/parisc/kernel/irq.c
    index e5fcfb70cc7c..cb48523e7d19 100644
    --- a/arch/parisc/kernel/irq.c
    +++ b/arch/parisc/kernel/irq.c
    @@ -560,20 +560,6 @@ void do_cpu_irq_mask(struct pt_regs *regs)
    goto out;
    }

    -static struct irqaction timer_action = {
    - .handler = timer_interrupt,
    - .name = "timer",
    - .flags = IRQF_TIMER | IRQF_PERCPU | IRQF_IRQPOLL,
    -};
    -
    -#ifdef CONFIG_SMP
    -static struct irqaction ipi_action = {
    - .handler = ipi_interrupt,
    - .name = "IPI",
    - .flags = IRQF_PERCPU,
    -};
    -#endif
    -
    static void claim_cpu_irqs(void)
    {
    int i;
    @@ -583,10 +569,13 @@ static void claim_cpu_irqs(void)
    }

    irq_set_handler(TIMER_IRQ, handle_percpu_irq);
    - setup_irq(TIMER_IRQ, &timer_action);
    + if (request_irq(TIMER_IRQ, timer_interrupt,
    + IRQF_TIMER | IRQF_PERCPU | IRQF_IRQPOLL, "timer", NULL))
    + pr_err("%s: request_irq() failed\n", "timer");
    #ifdef CONFIG_SMP
    irq_set_handler(IPI_IRQ, handle_percpu_irq);
    - setup_irq(IPI_IRQ, &ipi_action);
    + if (request_irq(IPI_IRQ, ipi_interrupt, IRQF_PERCPU, "IPI", NULL))
    + pr_err("%s: request_irq() failed\n", "IPI");
    #endif
    }

    diff --git a/drivers/parisc/eisa.c b/drivers/parisc/eisa.c
    index 9d00a24277aa..213d21f228e7 100644
    --- a/drivers/parisc/eisa.c
    +++ b/drivers/parisc/eisa.c
    @@ -243,11 +243,6 @@ static irqreturn_t dummy_irq2_handler(int _, void *dev)
    return IRQ_HANDLED;
    }

    -static struct irqaction irq2_action = {
    - .handler = dummy_irq2_handler,
    - .name = "cascade",
    -};
    -
    static void init_eisa_pic(void)
    {
    unsigned long flags;
    @@ -335,7 +330,8 @@ static int __init eisa_probe(struct parisc_device *dev)
    }

    /* Reserve IRQ2 */
    - setup_irq(2, &irq2_action);
    + if (request_irq(2, dummy_irq2_handler, 0, "cascade", NULL))
    + pr_err("%s: request_irq() failed\n", "cascade");
    for (i = 0; i < 16; i++) {
    irq_set_chip_and_handler(i, &eisa_interrupt_type,
    handle_simple_irq);
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-02-24 01:52    [W:7.394 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site