Messages in this thread | | | From | Vladimir Oltean <> | Date | Sat, 22 Feb 2020 14:33:05 +0200 | Subject | Re: [PATCH v2 net-next/devicetree 3/5] dt-bindings: net: dsa: ocelot: document the vsc9959 core |
| |
Hi Michael,
On Sat, 22 Feb 2020 at 13:28, Michael Walle <michael@walle.cc> wrote: > > > +Any port can be disabled, but the CPU port should be kept enabled. > > What is the reason for this? Do you mean if you actually want to use it? In > fact, I'd would like to see it disabled by default in the .dtsi file. It > doesn't make sense to just have the CPU port enabled, but not any of the > outgoing ports. It'd just confuse the user if there is an additional > network port which cannot be used. > > -michael >
I can disable all internal ports by default, but there is one configuration which will not work: enabling only eno3 and switch port 5. This is because the switch PCS registers belong to eno2, and if that is disabled, the memory accesses will be invalid. So providing a configuration with eno2 disabled by default is more likely to produce confusion. But I'll try to clarify better next time.
> > -- > > 2.17.1 > >
Thanks, -Vladimir
| |