lkml.org 
[lkml]   [2020]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 302/344] cifs: fix unitialized variable poential problem with network I/O cache lock patch
    Date
    From: Steve French <stfrench@microsoft.com>

    [ Upstream commit 463a7b457c02250a84faa1d23c52da9e3364aed2 ]

    static analysis with Coverity detected an issue with the following
    commit:

    Author: Paulo Alcantara (SUSE) <pc@cjr.nz>
    Date: Wed Dec 4 17:38:03 2019 -0300

    cifs: Avoid doing network I/O while holding cache lock

    Addresses-Coverity: ("Uninitialized pointer read")
    Reported-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
    Signed-off-by: Steve French <stfrench@microsoft.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/cifs/dfs_cache.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/cifs/dfs_cache.c b/fs/cifs/dfs_cache.c
    index 2faa05860a483..cf6cec59696c2 100644
    --- a/fs/cifs/dfs_cache.c
    +++ b/fs/cifs/dfs_cache.c
    @@ -1319,7 +1319,7 @@ static struct cifs_ses *find_root_ses(struct dfs_cache_vol_info *vi,
    char *mdata = NULL, *devname = NULL;
    struct TCP_Server_Info *server;
    struct cifs_ses *ses;
    - struct smb_vol vol;
    + struct smb_vol vol = {NULL};

    rpath = get_dfs_root(path);
    if (IS_ERR(rpath))
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-02-21 09:31    [W:8.809 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site