Messages in this thread | | | Date | Sat, 22 Feb 2020 12:40:54 +1100 | From | Herbert Xu <> | Subject | Re: [PATCH] crypto: chelsio - remove extra allocation for chtls_dev |
| |
On Fri, Jan 24, 2020 at 11:20:51PM +0100, Stephen Kitt wrote: > chtls_uld_add allocates room for info->nports net_device structs > following the chtls_dev struct, presumably because it was originally > intended that the ports array would be stored there. This is suggested > by the assignment which was present in initial versions and removed by > c4e848586cf1 ("crypto: chelsio - remove redundant assignment to > cdev->ports"): > > cdev->ports = (struct net_device **)(cdev + 1); > > This assignment was never used, being overwritten by lldi->ports > immediately afterwards, and I couldn't find any uses of the memory > allocated past the end of the struct. > > Signed-off-by: Stephen Kitt <steve@sk2.org> > --- > drivers/crypto/chelsio/chtls/chtls_main.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-)
Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |