lkml.org 
[lkml]   [2020]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 25/61] KVM: x86: Use u32 for holding CPUID register value in helpers
    Date
    Sean Christopherson <sean.j.christopherson@intel.com> writes:

    > Change the intermediate CPUID output register values from "int" to "u32"
    > to match both hardware and the storage type in struct cpuid_reg.
    >
    > No functional change intended.
    >
    > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
    > ---
    > arch/x86/kvm/cpuid.h | 6 +++---
    > 1 file changed, 3 insertions(+), 3 deletions(-)
    >
    > diff --git a/arch/x86/kvm/cpuid.h b/arch/x86/kvm/cpuid.h
    > index c1ac0995843d..72a79bdfed6b 100644
    > --- a/arch/x86/kvm/cpuid.h
    > +++ b/arch/x86/kvm/cpuid.h
    > @@ -95,7 +95,7 @@ static __always_inline struct cpuid_reg x86_feature_cpuid(unsigned x86_feature)
    > return reverse_cpuid[x86_leaf];
    > }
    >
    > -static __always_inline int *guest_cpuid_get_register(struct kvm_vcpu *vcpu, unsigned x86_feature)
    > +static __always_inline u32 *guest_cpuid_get_register(struct kvm_vcpu *vcpu, unsigned x86_feature)
    > {
    > struct kvm_cpuid_entry2 *entry;
    > const struct cpuid_reg cpuid = x86_feature_cpuid(x86_feature);
    > @@ -121,7 +121,7 @@ static __always_inline int *guest_cpuid_get_register(struct kvm_vcpu *vcpu, unsi
    >
    > static __always_inline bool guest_cpuid_has(struct kvm_vcpu *vcpu, unsigned x86_feature)
    > {
    > - int *reg;
    > + u32 *reg;
    >
    > reg = guest_cpuid_get_register(vcpu, x86_feature);
    > if (!reg)
    > @@ -132,7 +132,7 @@ static __always_inline bool guest_cpuid_has(struct kvm_vcpu *vcpu, unsigned x86_
    >
    > static __always_inline void guest_cpuid_clear(struct kvm_vcpu *vcpu, unsigned x86_feature)
    > {
    > - int *reg;
    > + u32 *reg;
    >
    > reg = guest_cpuid_get_register(vcpu, x86_feature);
    > if (reg)

    Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>

    --
    Vitaly

    \
     
     \ /
      Last update: 2020-02-21 16:45    [W:4.123 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site